Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Max video duration #3519

Closed
wants to merge 20 commits into from

Conversation

danielroek
Copy link
Contributor

@danielroek danielroek commented Feb 5, 2021

This PR adds functionality to limit a video recording in length.

Solves #23414.
Needs #3518 to be merged

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@danielroek danielroek marked this pull request as ready for review February 5, 2021 15:19
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

# Conflicts:
#	packages/camera/camera/CHANGELOG.md
#	packages/camera/camera/pubspec.yaml
#	packages/camera/camera_platform_interface/CHANGELOG.md
#	packages/camera/camera_platform_interface/lib/src/events/camera_event.dart
#	packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart
#	packages/camera/camera_platform_interface/pubspec.yaml
@danielroek danielroek closed this May 20, 2021
@mvanbeusekom mvanbeusekom deleted the max_video_duration branch September 21, 2021 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants