Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix the build-all exclusion list #3552

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Fix the build-all exclusion list #3552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99a5892
Allow plugin exclusions by just name
stuartmorgan-g Feb 15, 2021
75e1561
Try disabling all the exclusions to see which are still valid
stuartmorgan-g Feb 15, 2021
9e6fe8e
Add extension_google_sign_in_as_googleapis_auth to unmigrated list
stuartmorgan-g Feb 15, 2021
3fb4097
Merge branch 'master' into exclusion-list-fix
stuartmorgan-g Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 12 additions & 30 deletions script/build_all_plugins_app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,37 +18,19 @@ source "$SCRIPT_DIR/nnbd_plugins.sh"

check_changed_packages > /dev/null

# This list should be kept as short as possible, and things should remain here
# only as long as necessary, since in general the goal is for all of the latest
# versions of plugins to be mutually compatible.
#
# An example use case for this list would be to temporarily add plugins while
# updating multiple plugins for a breaking change in a common dependency in
# cases where using a relaxed version constraint isn't possible.
readonly EXCLUDED_PLUGINS_LIST=(
"connectivity_macos"
"connectivity_platform_interface"
"connectivity_web"
"extension_google_sign_in_as_googleapis_auth"
"file_selector" # currently out of sync with camera
"flutter_plugin_android_lifecycle"
"google_maps_flutter_platform_interface"
"google_maps_flutter_web"
"google_sign_in_platform_interface"
"google_sign_in_web"
"image_picker_platform_interface"
"image_picker"
"instrumentation_adapter"
"local_auth" # flutter_plugin_android_lifecycle conflict
"path_provider_linux"
"path_provider_macos"
"path_provider_platform_interface"
"path_provider_web"
"plugin_platform_interface"
"shared_preferences_linux"
"shared_preferences_macos"
"shared_preferences_platform_interface"
"shared_preferences_web"
"shared_preferences_windows"
"url_launcher_linux"
"url_launcher_macos"
"url_launcher_platform_interface"
"url_launcher_web"
"video_player_platform_interface"
"video_player_web"
# "file_selector" # currently out of sync with camera
# "flutter_plugin_android_lifecycle"
# "image_picker"
# "local_auth" # flutter_plugin_android_lifecycle conflict
"plugin_platform_interface" # This should never be a direct app dependency.
)
# Comma-separated string of the list above
readonly EXCLUDED=$(IFS=, ; echo "${EXCLUDED_PLUGINS_LIST[*]}")
Expand Down
9 changes: 2 additions & 7 deletions script/nnbd_plugins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,8 @@ readonly NNBD_PLUGINS_LIST=(
# building the all plugins app. This list should be kept empty.

readonly NON_NNBD_PLUGINS_LIST=(
#"camera"
"google_maps_flutter"
# "image_picker"
# "in_app_purchase"
# "quick_actions"
# "sensors"
# "wifi_info_flutter"
"extension_google_sign_in_as_googleapis_auth"
"google_maps_flutter" # partially migrated
)

export EXCLUDED_PLUGINS_FROM_STABLE=$(IFS=, ; echo "${NNBD_PLUGINS_LIST[*]}")
Expand Down
2 changes: 2 additions & 0 deletions script/tool/lib/src/common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,10 @@ abstract class PluginCommand extends Command<Null> {
// passed.
final String relativePath =
p.relative(subdir.path, from: packagesDir.path);
final String packageName = p.basename(subdir.path);
final String basenamePath = p.basename(entity.path);
if (!excludedPlugins.contains(basenamePath) &&
!excludedPlugins.contains(packageName) &&
!excludedPlugins.contains(relativePath) &&
(plugins.isEmpty ||
plugins.contains(relativePath) ||
Expand Down