-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Use flutter gcp project for linux tasks. #3733
Conversation
The failing test is because the driver doesn't support Chrome 89 yet, and anything that causes the image to be regenerated will get 89 currently. (Last time I looked I didn't see an obvious way to get a pinned version in the Docker file). I need to check on what the plan is for web integration tests on bots though; that specific test will be removed shortly. |
I've updated the integration test step, and was able to successfully run it with the newer Docker image after your webdriver change, so if you rebase this it should hopefully be green. |
5c8173e
to
8d49b27
Compare
.cirrus.yml
Outdated
@@ -110,16 +116,20 @@ task: | |||
build_script: | |||
- flutter config --enable-linux-desktop | |||
- ./script/incremental_build.sh build-examples --linux | |||
test_script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed? Separating these is helpful in looking at results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, merge conflict editing problem. Updating!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
Thanks for driving this! Looking forward to the improved throughput on presubmits :) |
Use flutter-cirrus for Cirrus Linux tasks in the plugins repository.
Bug: flutter/flutter#77624
Pre-launch Checklist
[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.