Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Use flutter gcp project for linux tasks. #3733

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

godofredoc
Copy link
Contributor

Use flutter-cirrus for Cirrus Linux tasks in the plugins repository.

Bug: flutter/flutter#77624

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 19, 2021

The failing test is because the driver doesn't support Chrome 89 yet, and anything that causes the image to be regenerated will get 89 currently. (Last time I looked I didn't see an obvious way to get a pinned version in the Docker file).

I need to check on what the plan is for web integration tests on bots though; that specific test will be removed shortly.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 20, 2021

I've updated the integration test step, and was able to successfully run it with the newer Docker image after your webdriver change, so if you rebase this it should hopefully be green.

.cirrus.yml Outdated
@@ -110,16 +116,20 @@ task:
build_script:
- flutter config --enable-linux-desktop
- ./script/incremental_build.sh build-examples --linux
test_script:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed? Separating these is helpful in looking at results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, merge conflict editing problem. Updating!

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@stuartmorgan-g
Copy link
Contributor

Thanks for driving this! Looking forward to the improved throughput on presubmits :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants