Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] 2/3 Quick actions federated platform interface #3735

Merged
merged 32 commits into from
Mar 20, 2021
Merged

[quick_actions] 2/3 Quick actions federated platform interface #3735

merged 32 commits into from
Mar 20, 2021

Conversation

danielroek
Copy link
Contributor

Implements a platform interface for the quick_actions plugin.

Please merge #3734 first!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@danielroek danielroek mentioned this pull request Mar 19, 2021
Merged
11 tasks
mvanbeusekom
mvanbeusekom suggested changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some references to the ImagePickerPlatform left in the API documentation of the quick_actions_platform.dart file. These should be fixed.

stuartmorgan-g
stuartmorgan-g reviewed Mar 19, 2021
View reviewed changes
packages/quick_actions/quick_actions_platform_interface/LICENSE Outdated
@@ -0,0 +1,25 @@
Copyright 2017 The Chromium Authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2013 The Flutter Authors

Same for all files in this PR, otherwise whichever of this and #3737 lands second will break the tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this in all the project files

mvanbeusekom
mvanbeusekom approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom mvanbeusekom merged commit 7b9ac6b into flutter:master Mar 20, 2021
@mvanbeusekom mvanbeusekom deleted the quick_actions_federated_platform_interface branch March 20, 2021 16:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
b7da6be 
flutter/plugins#3735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
b9bc302 
flutter/plugins#3735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
68b16ba 
flutter/plugins#3735)
@stuartmorgan-g
Copy link
Contributor

Published: https://pub.dev/packages/quick_actions_platform_interface

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
1d1751e 
flutter/plugins#3735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
031d1d4 
flutter/plugins#3735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
282dd37 
flutter/plugins#3735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
7b9ac6b [quick_actions] 2/3 Quick actions federated platform interface (
1da1149 
flutter/plugins#3735)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees
No one assigned
Labels
cla: yes p: quick_actions platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroek @stuartmorgan-g @mvanbeusekom