-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Expose the NSLocale object #3897
Conversation
This reverts commit 07fe2f5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Was there further discussion somewhere beyond what's in the issue? The issue suggested waiting and seeing if anyone actually needed this information before deciding to expose it, and I don't see anything there to suggest people have requested other information or provided use cases related to other fields, so it's not obvious why this is being done. |
Hi @stuartmorgan, this issue was on the list of "planned" items discussed offline between product managers. Since it was on the list treated as one of the issues agreed to be resolved. If you prefer we can rollback the changes and wait for more feedback on the issue. |
Yes, let's revert this; adding a lot of API surface to maintain without any known clients doesn't seem like a good tradeoff. |
* Expose remaining "simple" fields from NSLocale on SKProductWrapper. * Fix tests * Fix serialization * Format code * Updated version and changelog * Revert "Updated version and changelog" This reverts commit 07fe2f5. * Updated version and changelog
This PR exposes the majority of the NSLocale object via the SKProductWrapper.
The values for
NSLocaleExemplarCharacterSet
andNSLocaleCalendar
have been omitted, as they appear to be significantly more complex.Related issues:
Pre-launch Checklist
dart format
. See plugin_tool format)[shared_preferences]
///
).