Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Expose the NSLocale object #3897

Merged
merged 8 commits into from
May 18, 2021

Conversation

BeMacized
Copy link
Contributor

This PR exposes the majority of the NSLocale object via the SKProductWrapper.

The values for NSLocaleExemplarCharacterSet and NSLocaleCalendar have been omitted, as they appear to be significantly more complex.

Related issues:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BeMacized BeMacized merged commit e742a7b into flutter:master May 18, 2021
@stuartmorgan-g
Copy link
Contributor

Was there further discussion somewhere beyond what's in the issue? The issue suggested waiting and seeing if anyone actually needed this information before deciding to expose it, and I don't see anything there to suggest people have requested other information or provided use cases related to other fields, so it's not obvious why this is being done.

@mvanbeusekom
Copy link
Contributor

Was there further discussion somewhere beyond what's in the issue? The issue suggested waiting and seeing if anyone actually needed this information before deciding to expose it, and I don't see anything there to suggest people have requested other information or provided use cases related to other fields, so it's not obvious why this is being done.

Hi @stuartmorgan, this issue was on the list of "planned" items discussed offline between product managers. Since it was on the list treated as one of the issues agreed to be resolved. If you prefer we can rollback the changes and wait for more feedback on the issue.

@stuartmorgan-g
Copy link
Contributor

Yes, let's revert this; adding a lot of API surface to maintain without any known clients doesn't seem like a good tradeoff.

fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
* Expose remaining "simple" fields from NSLocale on SKProductWrapper.

* Fix tests

* Fix serialization

* Format code

* Updated version and changelog

* Revert "Updated version and changelog"

This reverts commit 07fe2f5.

* Updated version and changelog
@mvanbeusekom mvanbeusekom deleted the issue/26610 branch September 21, 2021 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants