-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Standardize XCTest locations and harnesses #4005
Standardize XCTest locations and harnesses #4005
Conversation
… the new standard location for the test files
…standard location for the test files
…move them from the RunnerUITests target to the RunnerTests target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll look tomorrow to figure out what I broke. |
CODE_SIGN_STYLE = Automatic; | ||
GCC_C_LANGUAGE_STANDARD = gnu11; | ||
INFOPLIST_FILE = RunnerTests/Info.plist; | ||
IPHONEOS_DEPLOYMENT_TARGET = 14.5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't override the project-level deployment target IPHONEOS_DEPLOYMENT_TARGET
or TARGETED_DEVICE_FAMILY
. I usually also don't override CLANG_*
, GCC_*
or MTL_*
but that's less important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot Xcode generates a bunch of target-level settings by default. Fixed, and I'll go add that to the docs.
To import the Flutter framework, the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure what I still have wrong in the new webview test target; I didn't see anything obvious comparing against one of the working projects. |
🤦🏻 Log reading fail on my part. Somehow I messed up the target membership of the test files in the webview test. |
- Moves XCTest files to the now-standard location - Ensures that the harnesses are called RunnerTests for consistency - Splits the image_picker unit tests out of the UI target into a new unit test target - Moves existing google_sign_in tests into the harness, since they weren't being run. One new test, added since we accidentally stopped compiling the file, was removed since it crashed other tests in the suite (which has non-trivial global state, so fixing it wasn't feasible here; I've follow up on the PR that added the test).
Pre-launch Checklist
dart format
. See plugin_tool format)[shared_preferences]
///
).