Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Add const constructor #4131

Merged
merged 5 commits into from
Jul 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/quick_actions/quick_actions/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.0+3

* Added a `const` constructor for the `QuickActions` class, so the plugin will behave as documented in the sample code mentioned in the [README.md](https://github.com/flutter/plugins/blob/59e16a556e273c2d69189b2dcdfa92d101ea6408/packages/quick_actions/quick_actions/README.md).

## 0.6.0+2

* Migrate maven repository from jcenter to mavenCentral.
Expand Down
3 changes: 3 additions & 0 deletions packages/quick_actions/quick_actions/lib/quick_actions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ export 'package:quick_actions_platform_interface/types/types.dart';

/// Quick actions plugin.
class QuickActions {
/// Creates a new instance of [QuickActions].
const QuickActions();

/// Initializes this plugin.
///
/// Call this once before any further interaction with the the plugin.
Expand Down
2 changes: 1 addition & 1 deletion packages/quick_actions/quick_actions/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for creating shortcuts on home screen, also known as
Quick Actions on iOS and App Shortcuts on Android.
repository: https://github.com/flutter/plugins/tree/master/packages/quick_actions
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+quick_actions%22
version: 0.6.0+2
version: 0.6.0+3

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,21 @@ void main() {
QuickActionsPlatform.instance = MockQuickActionsPlatform();
});

test('constructor() should return valid QuickActions instance', () {
const QuickActions quickActions = QuickActions();
expect(quickActions, isNotNull);
});

test('initialize() PlatformInterface', () async {
QuickActions quickActions = QuickActions();
const QuickActions quickActions = QuickActions();
QuickActionHandler handler = (type) {};

await quickActions.initialize(handler);
verify(QuickActionsPlatform.instance.initialize(handler)).called(1);
});

test('setShortcutItems() PlatformInterface', () {
QuickActions quickActions = QuickActions();
const QuickActions quickActions = QuickActions();
QuickActionHandler handler = (type) {};
quickActions.initialize(handler);
quickActions.setShortcutItems([]);
Expand All @@ -35,7 +40,7 @@ void main() {
});

test('clearShortcutItems() PlatformInterface', () {
QuickActions quickActions = QuickActions();
const QuickActions quickActions = QuickActions();
QuickActionHandler handler = (type) {};

quickActions.initialize(handler);
Expand Down