This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker_for_web] Support multiple pick. Store name and other local file properties in XFile. #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ditman can you please review this |
|
Ohhh, thanks @balvinderz! Definitely a very requested feature! Thanks for the contribution, I'll review right away! |
ditman
suggested changes
Jul 19, 2021
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Outdated
Show resolved
Hide resolved
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Outdated
Show resolved
Hide resolved
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Show resolved
Hide resolved
|
(Check file_selector_web, btw, there's probably a good example there!) |
ditman
reviewed
Jul 19, 2021
packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
Outdated
Show resolved
Hide resolved
|
Tests are failing with: Please run the tests in your machine ;) |
|
This is looking great! I'll give this a quick test in my box and have it ready to merge by EOD. Thanks for the contribution @balvinderz! Keep them coming! |
* Removed redundant getFile method (getFiles already exists) * Added tests to verify that 'multiple' attribute is set in file input * Added tests to verify that extra metadata is set. * Added some , to improve dart format output.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ditman
approved these changes
Jul 19, 2021
ditman
added
the
waiting for tree to go green
ditman
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
…other local file properties in XFile. (flutter/plugins#4166)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
…other local file properties in XFile. (flutter/plugins#4166)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…cal file properties in XFile. (flutter#4166)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
…cal file properties in XFile. (flutter#4166)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for picking multiple image , and store name and other properties in XFile
Fixes flutter/flutter#86525
Fixes flutter/flutter#58764
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.