This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera_web] Add availableCameras
implementation
#4175
Merged
fluttergithubbot
merged 15 commits into
flutter:master
from
VeryGoodOpenSource:feat/camera-web-available-cameras
Jul 22, 2021
Merged
[camera_web] Add availableCameras
implementation
#4175
fluttergithubbot
merged 15 commits into
flutter:master
from
VeryGoodOpenSource:feat/camera-web-available-cameras
Jul 22, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es is not supported
ditman
reviewed
Jul 21, 2021
ditman
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, I'm going to try and implement my own comments for this PR so we can keep going :)
packages/camera/camera_web/example/integration_test/types/camera_metadata_test.dart
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 380e7fb.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: camera
platform-web
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
availableCameras
implementation of the camera platform interface.MediaDeviceKind
- represents a kind of a media device (video input, audio input, audio output). Used when filtering video input devices inavailableCameras
.CameraSettings
- a utility to fetch and map camera settings. Used to extract the camera lens direction from the video track. Currently supports the following methods:CameraMetadata
used along theCameraDescription
to store additional web-specific camera details. They are going to be used when creating a camera later.availableCameras
implementation.Temporarily added(Reverted by @ditman, this dependency can be added to any app needing this package directly, not necessarily to thecamera_web
to camera example pubspec.camera
plugin)Part of flutter/flutter#45297.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).