Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Make plugin publishable for the first time. #4304

Merged
merged 5 commits into from
Sep 3, 2021
Merged

[camera_web] Make plugin publishable for the first time. #4304

merged 5 commits into from
Sep 3, 2021

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 2, 2021 •
edited
Loading

This PR gets the camera_web package ready to publish into pub.dev, as v0.2.0

(Partially addresses flutter/flutter#45297)

  • Clarify in the README that the plugin is not endorsed yet.
  • Tweak the list of not-supported operations
  • Call this v0.2.0

Thanks @bselwe!!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
[camera_web] Make plugin publishable for the first time.
9214b8c 
* Clarify in the README that the plugin is not endorsed yet.
* Tweak the list of not-supported operations
* Call this v 0.6.0
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@ditman
Copy link
Member Author

ditman commented Sep 2, 2021

(Heads up @mvanbeusekom, @BeMacized; web support is finally coming!)

@ditman
Copy link
Member Author

ditman commented Sep 2, 2021 

ERROR: * line 16, column 1 of lib/src/camera_web.dart: This package does not have stream_transform in the `dependencies` section of `pubspec.yaml`.

Nice check! I'll fix it right away! (I wish it was part of the analyzer checks, and not something on pre-publish)

@ditman ditman removed the request for review from bparrishMines September 2, 2021 23:34
stuartmorgan-g
stuartmorgan-g approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update the PR description to s/0.6.0/0.2.0/ before landing though.

@ditman
Update README.md
6c4bc9b
@ditman
Update README.md
6a5b7b8 
Remove unused link at the bottom of the file.
@ditman
Copy link
Member Author

ditman commented Sep 3, 2021

Please update the PR description to s/0.6.0/0.2.0/ before landing though.

@stuartmorgan I think I scrubbed all the references to 0.6.0, thanks for the reminder!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 3, 2021
@fluttergithubbot fluttergithubbot merged commit 597771f into flutter:master Sep 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
6739a05 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
8c27189 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 3, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
397de94 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
864261a 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
c31733e 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
86faff7 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
2c4a544 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
8cfe641 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
bf64c8e 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
bba2ba8 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
dca09a2 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
0a38593 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
13131f6 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
a9aad2c 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
0a16eee 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
7fae14e 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
256f1ea 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
ca5cfe4 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
dc704fa 
…tter/plugins#4304)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
597771f [camera_web] Make plugin publishable for the first time. (flu…
8b462a8 
…tter/plugins#4304)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ditman @fotiDim
[camera_web] Make plugin publishable for the first time. (flutter#4304)
e26610f
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@ditman @amantoux
[camera_web] Make plugin publishable for the first time. (flutter#4304)
d93045e
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@ditman @KyleFin
[camera_web] Make plugin publishable for the first time. (flutter#4304)
7d63f01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @stuartmorgan-g @fluttergithubbot