Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Update lewagon/wait-on-check-action to latest version. #4326

Merged

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 8, 2021

Similar to flutter/packages/pull/461, this PR updates the version of lewagon/wait-on-check-action on the release workflow so it waits for more than 30 checks.

Fixes: flutter/flutter#88120

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz
Copy link
Contributor

cyanglaz commented Sep 8, 2021

LGTM, can land when the new hash is white listed by @godofredoc

@godofredoc
Copy link
Contributor

LGTM, can land when the new hash is white listed by @godofredoc

It is added already to the allowlist.

@ditman
Copy link
Member Author

ditman commented Sep 8, 2021

Correct, this version is already added to the allow-list; @cyanglaz this is the internal bug that @godofredoc and I are using to coordinate this: b/199300032

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 8, 2021
@fluttergithubbot fluttergithubbot merged commit f988f61 into flutter:master Sep 8, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@ditman ditman deleted the update-wait-on-check-action-plugins branch September 8, 2021 22:25
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 8, 2021
* master:
  [ci] Update lewagon/wait-on-check-action to latest version. (flutter#4326)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugins] release action not waiting for all checks to complete.
4 participants