Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Initialize player when size and duration become available #4438

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 19, 2021

Consistently on iOS 15 the AVPlayerItem.status is AVPlayerItemStatusReadyToPlay, but the presentationSize is zero.
So it falls through here, and there's never another attempt to initialize the video.

if (height == CGSizeZero.height && width == CGSizeZero.width) {
return;
}

Instead, KVO on presentationSize and duration, then sendInitialized if AVPlayerItemStatusReadyToPlay.

From the presentationSize docs:

You can use key-value observing to obtain the player item’s valid presentation size as early as possible

duration:

  • Wait until the status of the player item is AVPlayerItemStatusReadyToPlay.
  • Register for key-value observation of the property, requesting the initial value. If the initial value is reported as kCMTimeIndefinite, the player item will notify you of the availability of its duration via key-value observing as soon as its value becomes known.

Additionally, update the iOS UI tests to actually play the video, check closed captioning, and adjust playback speed.

Fixes flutter/flutter#91975

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment nits.

AVPlayerItem* item = (AVPlayerItem*)object;
if (item.status == AVPlayerItemStatusReadyToPlay) {
// When the player item is ready, it still may not have determined its presentation size or
// duration. When these properties are finally set, initialize the player.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe s/initialize the player/re-check whether it's fully initiailized/. Due to the poor naming of sendInitialized I thought this would send initialization multiple times, and possibly too early (when only one or the other but not both were set).

The real problem is the method name, but adjusting the comment would help.

Copy link
Member Author

@jmagman jmagman Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the comment, and the method to setupEventSinkIfReadyToPlay.

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 27, 2021
@fluttergithubbot fluttergithubbot merged commit 76e84c0 into flutter:master Oct 27, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Oct 27, 2021
* master:
  [ci.yaml] Main branch support (flutter#4440)
  [video_player] Initialize player when size and duration become available (flutter#4438)
  [webview_flutter] Implement zoom enabled for ios and android (flutter#4417)
  Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453)
@jmagman jmagman deleted the video-player-init branch October 27, 2021 23:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2021
hofmannfelix pushed a commit to hofmannfelix/plugins that referenced this pull request Oct 30, 2021
…ideo_src_on_same_controller

* commit '76e84c0679dbab7bfaaaa553b17bb0dbdb9a3c33': (537 commits)
  [video_player] Initialize player when size and duration become available (flutter#4438)
  [webview_flutter] Implement zoom enabled for ios and android (flutter#4417)
  Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453)
  Implement Android WebView api with pigeon (Java portion) (flutter#4441)
  [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434)
  Implement Android WebView api with pigeon (Dart portion)  (flutter#4435)
  upgraded usage of BinaryMessenger (flutter#4451)
  [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428)
  Use OpenJDK 11 in CI jobs  (flutter#4419)
  [google_sign_in] remove the commented out code in tests (flutter#4442)
  [webview] Fix typos in the README (flutter#4249)
  [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180)
  [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429)
  [shared_preferences] Switch to new analysis options (flutter#4384)
  [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413)
  [camera] Run iOS methods on UI thread by default (flutter#4140)
  [ci] Always run all `format` steps (flutter#4427)
  [flutter_plugin_tools] Fix license-check on Windows (flutter#4425)
  [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400)
  [image_picker][android] suppress unchecked warning (flutter#4408)
  ...

# Conflicts:
#	packages/video_player/video_player/pubspec.yaml
#	packages/video_player/video_player_web/lib/video_player_web.dart
#	packages/video_player/video_player_web/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: video_player platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[video_player] some hls(m3u8) format video are not initializing on ios 15
3 participants