-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Update webview_flutter documentation #4481
[webview_flutter] Update webview_flutter documentation #4481
Conversation
@stuartmorgan @bparrishMines @mvanbeusekom This slipped by me as the example app already has |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a follow-up PR to #3325. After updating our repo to use version 3.2.0, I realized that in order to actually disable zoom on iOS, we have to set
javascriptMode: JavascriptMode.unrestricted
as iOS uses javascript to disable zoom.This PR just updates the documentation to reflect this.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#75196
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.