This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Don't restart when scrubbing to end #4488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced by flutter#3727 where scrubbing a progress indicator to the end of the video while playing would unexpectedly restart playback from the start of the video. Restarting is an intentional behavior under the assumption that `play` is called for a deliberate user action to start playback, but in the case of scrubbing it is a programatic pause/play pair where the decision to call `play` again should account for scrubbing to the end. Fixes flutter/flutter#92658
ditman
approved these changes
Nov 8, 2021
Comment on lines
+787
to
+788
| if (_controllerWasPlaying && | ||
| controller.value.position != controller.value.duration) { |
There was a problem hiding this comment.
I was looking at how this is handled in QT Player and it seems they also use the "looping" setting to determine what to do:
wasPlaying + scrolledToEnd + looping: jump and pause in FIRST frame of the video.wasPlaying + scrolledToEnd + !looping: pause in last frame. This is the same as!wasPlaying + scrolledToEnd, regardless of value of looping.)
In all cases above, clicking "Play", immediately starts the video from the beginning.
In no case QT restarted when scrubbing to the end.
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #3727 where scrubbing a progress
indicator to the end of the video while playing would unexpectedly
restart playback from the start of the video. Restarting is an
intentional behavior under the assumption that
playis called for adeliberate user action to start playback, but in the case of scrubbing
it is a programatic pause/play pair where the decision to call
playagain should account for scrubbing to the end.
Fixes flutter/flutter#92658
Pre-launch Checklist
dart format.)[shared_preferences]///).