This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[local_auth] Fix deviceSupportsBiometrics returning false on iOS when present biometric hardware is not enrolled. #5329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
stuartmorgan-g
approved these changes
Apr 22, 2022
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_ios/example/ios/RunnerTests/FLTLocalAuthPluginTests.m
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2022
…n iOS when present biometric hardware is not enrolled. (flutter/plugins#5329)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
… present biometric hardware is not enrolled. (flutter#5329) * Fix deviceSupportsBiometrics returning false when hardware is available but not enrolled. * Fix label * Format * Add unit tests * Fix changelog * Revert additions to project.pbxproj * Implement PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom implementation for
deviceSupportsBiometricsto return true when biometric hardware is present, but not enrolled, as per the current documentation.Additionally, it removes the confusing
undefinedvalue fromgetEnrolledBiometrics.These are the same changes that happened for
local_auth_androidin:Semi-related to flutter/flutter#45497.
Relevant discussion: #5309 (comment)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).