Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] fix lock orientation when pausing preview #5332

Closed

Conversation

martingeorgiu
Copy link
Contributor

When calling pausePreview(), there was lockedCaptureOrientation ignored, which made the camera preview flip when calling the pause

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@martingeorgiu
Copy link
Contributor Author

There is no issue for this PR, should I create one then? It's pretty much straight forward so I've made the change right away.

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission!

There is no issue for this PR, should I create one then? It's pretty much straight forward so I've made the change right away.

It would be helpful to have an issue filed with detailed repro steps, so that someone reviewing can easily get more information about the exact problem this is intended to fix. It's also good to have the bug captured in case the PR is never completed.

The other elements of the PR checklist are required as well (except for documentation, in this case); I'm going to mark this as a Draft, and once it's complete you can mark it as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft April 22, 2022 15:02
@cassioso
Copy link
Contributor

cassioso commented Apr 23, 2022

Developers of the world, unite! 😄
#5209

Edit: issue reported flutter/flutter#102744

@martingeorgiu
Copy link
Contributor Author

@cassioso oh I missed that one, closing as it is clear duplicate

@martingeorgiu martingeorgiu deleted the fix/cameraLockedOrientation branch April 26, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants