Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_android] Updates pigeon version to support null safety #5395

Merged
merged 9 commits into from
Apr 28, 2022
Merged

[webview_flutter_android] Updates pigeon version to support null safety #5395

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ed2ce9
start of null transition
bparrishMines Apr 6, 2022
efd00b1
dart side nullability
bparrishMines Apr 14, 2022
cef72a0
Merge branch 'main' of github.com:flutter/plugins into android_null
bparrishMines Apr 25, 2022
abfb2ac
update java pigeon code
bparrishMines Apr 26, 2022
6ea4960
update changelog message
bparrishMines Apr 26, 2022
611c248
default empty value for request headers
bparrishMines Apr 27, 2022
0b79c12
test
bparrishMines Apr 27, 2022
6c639fe
version bump and constructors
bparrishMines Apr 28, 2022
b1230e4
Merge branch 'master' of github.com:flutter/plugins into android_null
bparrishMines Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/webview_flutter/webview_flutter_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates pigeon developer dependency to the latest version which adds support for null safety.

## 2.8.5

* Migrates deprecated `Scaffold.showSnackBar` to `ScaffoldMessenger` in example app.
Expand Down
8 changes: 6 additions & 2 deletions packages/webview_flutter/webview_flutter_android/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ normally. This package will be automatically included in your app when you do.

## Contributing

This package uses [pigeon][3] to generate the communication layer between Flutter and the host platform (Android). The communication interface is defined in the `pigeons/android_webview.dart` file. After editing the communication interface regenerate the communication layer by running the `./generatePigeons.sh` shell script.
This package uses [pigeon][3] to generate the communication layer between Flutter and the host
platform (Android). The communication interface is defined in the `pigeons/android_webview.dart`
file. After editing the communication interface regenerate the communication layer by running
`flutter pub run pigeon --input pigeons/android_webview.dart`.

Due to [flutter/flutter#97744](https://github.com/flutter/flutter/issues/97744), the generated test
pigeon file needs one of its imports updated to properly work with `mockito`.
Expand All @@ -26,7 +29,8 @@ to
import 'package:webview_flutter_android/src/android_webview.pigeon.dart';
```

Besides [pigeon][3] this package also uses [mockito][4] to generate mock objects for testing purposes. To generate the mock objects run the following command:
Besides [pigeon][3] this package also uses [mockito][4] to generate mock objects for testing
purposes. To generate the mock objects run the following command:
```bash
flutter packages pub run build_runner build --delete-conflicting-outputs
```
Expand Down
Loading