Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix XCUITest based on the new tooltip accessibility label #5426

Merged
merged 5 commits into from
Apr 28, 2022
Merged

[video_player] Fix XCUITest based on the new tooltip accessibility label #5426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72d4b90
fix test
Apr 27, 2022
1781c6a
shorten wait and fix typo
Apr 28, 2022
66dc1d3
fix another typo
Apr 28, 2022
5e4f255
only look for the 1.0x and 5.0x part
Apr 28, 2022
b169aa4
review
Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.3.3

* Fix XCUITest based on the new voice over announcement for tooltips.
See: https://github.com/flutter/flutter/pull/87684

## 2.3.2

* Applies the standardized transform for videos with different orientations.
Expand Down
12 changes: 8 additions & 4 deletions ...ges/video_player/video_player_avfoundation/example/ios/RunnerUITests/VideoPlayerUITests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,20 @@ - (void)testPlayVideo {
XCTAssertTrue([playButton waitForExistenceWithTimeout:30.0]);
[playButton tap];

XCUIElement *playbackSpeed1x = app.staticTexts[@"Playback speed\n1.0x"];
XCTAssertTrue([playbackSpeed1x waitForExistenceWithTimeout:30.0]);
NSPredicate *find1xButton = [NSPredicate predicateWithFormat:@"label CONTAINS '1.0x'"];
XCUIElement *playbackSpeed1x = [app.staticTexts elementMatchingPredicate:find1xButton];
BOOL foundPlaybackSpeed1x = [playbackSpeed1x waitForExistenceWithTimeout:30.0];
XCTAssertTrue(foundPlaybackSpeed1x);
[playbackSpeed1x tap];

XCUIElement *playbackSpeed5xButton = app.buttons[@"5.0x"];
XCTAssertTrue([playbackSpeed5xButton waitForExistenceWithTimeout:30.0]);
[playbackSpeed5xButton tap];

XCUIElement *playbackSpeed5x = app.staticTexts[@"Playback speed\n5.0x"];
XCTAssertTrue([playbackSpeed5x waitForExistenceWithTimeout:30.0]);
NSPredicate *find5xButton = [NSPredicate predicateWithFormat:@"label CONTAINS '5.0x'"];
XCUIElement *playbackSpeed5x = [app.staticTexts elementMatchingPredicate:find5xButton];
BOOL foundPlaybackSpeed5x = [playbackSpeed5x waitForExistenceWithTimeout:30.0];
XCTAssertTrue(foundPlaybackSpeed5x);

// Cycle through tabs.
for (NSString *tabName in @[ @"Asset", @"Remote" ]) {
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_avfoundation
description: iOS implementation of the video_player plugin.
repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_avfoundation
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.3.2
version: 2.3.3

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down