Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker_ios] build error #5744

Closed
wants to merge 2 commits into from
Closed

[image_picker_ios] build error #5744

wants to merge 2 commits into from

Conversation

cdoky
Copy link

@cdoky cdoky commented May 15, 2022

fixed: flutter/flutter#103836

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

FLTImagePickerPlugin_Test.h:9:9: 'messages.g.h' file not found with <angled> include; use "quotes" instead
@cdoky cdoky requested a review from cyanglaz as a code owner May 15, 2022 01:50
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cdoky cdoky changed the title - fixed: xcode build error [image_picker_ios] build error May 15, 2022
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission, but this will be fixed by #5635

(In the future please don't check all of the checklist items without actually doing the steps.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image_picker_ios] build ios-framework error
2 participants