[camera] flip/change camera while recording

packages/camera/camera/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.0
+
+* Allows camera to be switched while video recording.
+
 ## 0.10.0+4
 
 * Removes usage of `_ambiguate` method in example.

packages/camera/camera/README.md

@@ -75,7 +75,7 @@ void didChangeAppLifecycleState(AppLifecycleState state) {
   if (state == AppLifecycleState.inactive) {
     cameraController.dispose();
   } else if (state == AppLifecycleState.resumed) {
-    onNewCameraSelected(cameraController.description);
+    onNewCameraSelected(cameraController.value.description);
   }
 }
 ```

packages/camera/camera/example/integration_test/camera_test.dart

@@ -56,7 +56,7 @@ void main() {
       CameraController controller, ResolutionPreset preset) async {
     final Size expectedSize = presetExpectedSizes[preset]!;
     print(
-        'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}');
+        'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.value.description.name}');
 
     // Take Picture
     final XFile file = await controller.takePicture();
@@ -105,7 +105,7 @@ void main() {
       CameraController controller, ResolutionPreset preset) async {
     final Size expectedSize = presetExpectedSizes[preset]!;
     print(
-        'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}');
+        'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.value.description.name}');
 
     // Take Video
     await controller.startVideoRecording();
@@ -269,6 +269,29 @@ void main() {
     return completer.future;
   }
 
+  testWidgets('Set description while recording', (WidgetTester tester) async {
+    final List<CameraDescription> cameras = await availableCameras();
+    if (cameras.length < 2) {
+      return;
+    }
+
+    final CameraController controller = CameraController(
+      cameras[0],
+      ResolutionPreset.low,
+      enableAudio: false,
+    );
+
+    await controller.initialize();
+    await controller.prepareForVideoRecording();
+
+    await controller.startVideoRecording();
+    sleep(const Duration(milliseconds: 500));
+    await controller.setDescriptionWhileRecording(cameras[1]);
+    sleep(const Duration(milliseconds: 500));
+
+    expect(controller.value.description, cameras[1]);
+  });
+
   testWidgets(
     'iOS image streaming with imageFormatGroup',
     (WidgetTester tester) async {

packages/camera/camera/example/ios/Runner.xcodeproj/project.pbxproj

@@ -174,6 +174,7 @@
 				TargetAttributes = {
 					97C146ED1CF9000F007C117D = {
 						CreatedOnToolsVersion = 7.3.1;
+						DevelopmentTeam = "";
 					};
 				};
 			};

packages/camera/camera/example/lib/main.dart

@@ -121,7 +121,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     if (state == AppLifecycleState.inactive) {
       cameraController.dispose();
     } else if (state == AppLifecycleState.resumed) {
-      onNewCameraSelected(cameraController.description);
+      onNewCameraSelected(cameraController.value.description);
     }
   }
   // #enddocregion AppLifecycle
@@ -596,12 +596,9 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
             width: 90.0,
             child: RadioListTile<CameraDescription>(
               title: Icon(getCameraLensIcon(cameraDescription.lensDirection)),
-              groupValue: controller?.description,
+              groupValue: controller?.value.description,
               value: cameraDescription,
-              onChanged:
-                  controller != null && controller!.value.isRecordingVideo
-                      ? null
-                      : onChanged,
+              onChanged: onChanged,
             ),
           ),
         );
@@ -634,6 +631,14 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
   }
 
   Future<void> onNewCameraSelected(CameraDescription cameraDescription) async {
+    // if we are currently recording then switch the camera description of the controller to flip the camera
+    final bool isRecording =
+        controller != null && controller!.value.isRecordingVideo;
+    if (isRecording) {
+      controller!.setDescriptionWhileRecording(cameraDescription);
+      return;
+    }
+
     final CameraController? oldController = controller;
     if (oldController != null) {
       // `controller` needs to be set to null before getting disposed,
@@ -768,7 +773,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
   void onAudioModeButtonPressed() {
     enableAudio = !enableAudio;
     if (controller != null) {
-      onNewCameraSelected(controller!.description);
+      onNewCameraSelected(controller!.value.description);
     }
   }
 

packages/camera/camera/example/pubspec.yaml

@@ -30,3 +30,8 @@ dev_dependencies:
 
 flutter:
   uses-material-design: true
+
+# FOR TESTING ONLY. DO NOT MERGE.
+dependency_overrides:
+  camera_platform_interface:
+    path: ../../../camera/camera_platform_interface

packages/camera/camera/lib/src/camera_controller.dart

@@ -49,14 +49,15 @@ class CameraValue {
     required this.exposurePointSupported,
     required this.focusPointSupported,
     required this.deviceOrientation,
+    required this.description,
     this.lockedCaptureOrientation,
     this.recordingOrientation,
     this.isPreviewPaused = false,
     this.previewPauseOrientation,
   }) : _isRecordingPaused = isRecordingPaused;
 
   /// Creates a new camera controller state for an uninitialized controller.
-  const CameraValue.uninitialized()
+  const CameraValue.uninitialized(CameraDescription description)
       : this(
           isInitialized: false,
           isRecordingVideo: false,
@@ -70,6 +71,7 @@ class CameraValue {
           focusPointSupported: false,
           deviceOrientation: DeviceOrientation.portraitUp,
           isPreviewPaused: false,
+          description: description,
         );
 
   /// True after [CameraController.initialize] has completed successfully.
@@ -143,6 +145,9 @@ class CameraValue {
   /// The orientation of the currently running video recording.
   final DeviceOrientation? recordingOrientation;
 
+  /// The properties of the camera device controlled by this controller.
+  final CameraDescription description;
+
   /// Creates a modified copy of the object.
   ///
   /// Explicitly specified fields get the specified value, all other fields get
@@ -165,6 +170,7 @@ class CameraValue {
     Optional<DeviceOrientation>? recordingOrientation,
     bool? isPreviewPaused,
     Optional<DeviceOrientation>? previewPauseOrientation,
+    CameraDescription? description,
   }) {
     return CameraValue(
       isInitialized: isInitialized ?? this.isInitialized,
@@ -191,6 +197,7 @@ class CameraValue {
       previewPauseOrientation: previewPauseOrientation == null
           ? this.previewPauseOrientation
           : previewPauseOrientation.orNull,
+      description: description ?? this.description,
     );
   }
 
@@ -211,7 +218,8 @@ class CameraValue {
         'lockedCaptureOrientation: $lockedCaptureOrientation, '
         'recordingOrientation: $recordingOrientation, '
         'isPreviewPaused: $isPreviewPaused, '
-        'previewPausedOrientation: $previewPauseOrientation)';
+        'previewPausedOrientation: $previewPauseOrientation, '
+        'description: $description)';
   }
 }
 
@@ -225,14 +233,11 @@ class CameraValue {
 class CameraController extends ValueNotifier<CameraValue> {
   /// Creates a new camera controller in an uninitialized state.
   CameraController(
-    this.description,
+    CameraDescription description,
     this.resolutionPreset, {
     this.enableAudio = true,
     this.imageFormatGroup,
-  }) : super(const CameraValue.uninitialized());
-
-  /// The properties of the camera device controlled by this controller.
-  final CameraDescription description;
+  }) : super(CameraValue.uninitialized(description));
 
   /// The resolution this controller is targeting.
   ///
@@ -294,7 +299,7 @@ class CameraController extends ValueNotifier<CameraValue> {
       });
 
       _cameraId = await CameraPlatform.instance.createCamera(
-        description,
+        value.description,
         resolutionPreset,
         enableAudio: enableAudio,
       );
@@ -380,6 +385,20 @@ class CameraController extends ValueNotifier<CameraValue> {
     }
   }
 
+  /// Sets the description while the camera is recording.
+  Future<void> setDescriptionWhileRecording(
+      CameraDescription description) async {
+    if (!value.isRecordingVideo) {
+      throw CameraException(
+        'Video was not being recorded',
+        'setDescriptionWhileRecording was called while a video was not being recorded',
+      );
+    }
+
+    await CameraPlatform.instance.setDescriptionWhileRecording(description);
+    value = value.copyWith(description: description);
+  }
+
   /// Captures an image and returns the file where it was saved.
   ///
   /// Throws a [CameraException] if the capture fails.

packages/camera/camera/pubspec.yaml

@@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
   Dart.
 repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.10.0+4
+version: 0.11.0
 
 environment:
   sdk: ">=2.14.0 <3.0.0"
@@ -38,3 +38,13 @@ dev_dependencies:
   mockito: ^5.0.0
   plugin_platform_interface: ^2.0.0
   video_player: ^2.0.0
+
+
+# FOR TESTING ONLY. DO NOT MERGE.
+dependency_overrides:
+  camera_android:
+    path: ../../camera/camera_android
+  camera_avfoundation:
+    path: ../../camera/camera_avfoundation
+  camera_platform_interface:
+    path: ../../camera/camera_platform_interface

packages/camera/camera/test/camera_preview_test.dart

@@ -12,7 +12,10 @@ import 'package:quiver/core.dart';
 
 class FakeController extends ValueNotifier<CameraValue>
     implements CameraController {
-  FakeController() : super(const CameraValue.uninitialized());
+  FakeController() : super(const CameraValue.uninitialized(fakeDescription));
+
+  static const CameraDescription fakeDescription = CameraDescription(
+      name: '', lensDirection: CameraLensDirection.back, sensorOrientation: 0);
 
   @override
   Future<void> dispose() async {
@@ -30,10 +33,6 @@ class FakeController extends ValueNotifier<CameraValue>
   @override
   void debugCheckIsDisposed() {}
 
-  @override
-  CameraDescription get description => const CameraDescription(
-      name: '', lensDirection: CameraLensDirection.back, sensorOrientation: 0);
-
   @override
   bool get enableAudio => false;
 
@@ -117,6 +116,10 @@ class FakeController extends ValueNotifier<CameraValue>
 
   @override
   Future<void> resumePreview() async {}
+
+  @override
+  Future<void> setDescriptionWhileRecording(
+      CameraDescription description) async {}
 }
 
 void main() {

packages/camera/camera/test/camera_test.dart

@@ -360,6 +360,30 @@ void main() {
           )));
     });
 
+    test(
+        'setDescriptionWhileRecording() throws $CameraException when not currenctly recording',
+        () async {
+      final CameraController cameraController = CameraController(
+          const CameraDescription(
+              name: 'cam',
+              lensDirection: CameraLensDirection.back,
+              sensorOrientation: 90),
+          ResolutionPreset.max);
+
+      await cameraController.initialize();
+      const CameraDescription newDescription = CameraDescription(
+          name: 'cam2',
+          lensDirection: CameraLensDirection.front,
+          sensorOrientation: 90);
+      expect(
+          cameraController.setDescriptionWhileRecording(newDescription),
+          throwsA(isA<CameraException>().having(
+            (CameraException error) => error.description,
+            'Video was not being recorded',
+            'setDescriptionWhileRecording was called while a video was not being recorded',
+          )));
+    });
+
     test('getMaxZoomLevel() throws $CameraException when uninitialized',
         () async {
       final CameraController cameraController = CameraController(