Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Add getDirectoryPaths method to the file_selector #6576

Conversation

eugerossetto
Copy link
Contributor

@eugerossetto eugerossetto commented Oct 14, 2022

This PR adds the file_selector implementation for retrieving multiple directories paths from a select folder dialog.

This is a continuation of PR #6572, PR #6573 and PR #6575 so these changes will be ready to merge once the new version 2.3.0 in file_selector_platform_interface becomes available and the Linux and MacOS implementations are ready, before that, there's no point for this to be merged.

Issue:
Support for selection of multiple directories, through desktop's native open panel, in 'file_selector' package #74323

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@adpinola adpinola force-pushed the 74323-add-get-directories-paths-file-selector branch from be428c5 to 797005c Compare October 14, 2022 20:36
@eugerossetto eugerossetto force-pushed the 74323-add-get-directories-paths-file-selector branch from 797005c to 25c1bbb Compare October 31, 2022 15:51
@eugerossetto eugerossetto changed the title [file_selector] Add getDirectoriesPaths method to the file_selector [file_selector] Add getDirectoryPaths method to the file_selector Oct 31, 2022
@adpinola adpinola force-pushed the 74323-add-get-directories-paths-file-selector branch from 0683c05 to 57561d1 Compare November 2, 2022 14:59
@stuartmorgan-g
Copy link
Contributor

Update from triage: this is still waiting on the implemention PRs to be reviewed and landed.

@stuartmorgan-g
Copy link
Contributor

Status update:

@stuartmorgan-g
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants