Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Update web mocks. #6591

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[ci] Update web mocks. #6591

merged 3 commits into from
Oct 20, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Oct 19, 2022

This PR updates the mockito mocks of the following web packages:

  • google_maps_flutter_web
  • url_launcher_web
  • webview_flutter_web (these had been manually modified to land a roll a while back)

Fixes flutter/flutter#97815

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Copy link
Member Author

ditman commented Oct 19, 2022

�[36m[0:00] Running for google_maps_flutter_web...�[0m
  No version change.
  Found NEXT; validating next version in the CHANGELOG.
�[31mNo CHANGELOG change found. If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG, comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the "override: no changelog needed" label. Otherwise, please add a NEXT entry in the CHANGELOG as described in the contributing guide.�[0m
�[36m[0:00] Running for url_launcher_web...�[0m
  No version change.
  Found NEXT; validating next version in the CHANGELOG.
�[31mNo CHANGELOG change found. If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG, comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the "override: no changelog needed" label. Otherwise, please add a NEXT entry in the CHANGELOG as described in the contributing guide.�[0m

This is only updating mock files in google_maps_flutter_web and url_launcher_web tests, I don't think this warrants a changelog entry.

�[36m[0:00] Running for webview_flutter_web...�[0m
  No version change.
  Found NEXT; validating next version in the CHANGELOG.
�[31mNo version change found, but the change to this package could not be verified to be exempt from version changes according to repository policy. If this is a false positive, please comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the "override: no versioning needed" label.�[0m

I think removing some build_tool dependencies from the pubspec.yaml triggered the versioning alert for webview_flutter_web. I don't think this change warrants a new version.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ditman
Copy link
Member Author

ditman commented Oct 20, 2022

Removing "needs tests" since this PR is updating the mocks used to run in CI.

@stuartmorgan-g
Copy link
Contributor

This is only updating mock files in google_maps_flutter_web and url_launcher_web tests, I don't think this warrants a changelog entry.
..
I think removing some build_tool dependencies from the pubspec.yaml triggered the versioning alert for webview_flutter_web. I don't think this change warrants a new version.

Yep, flutter/flutter#103602 is tracking making this check understand dev_dependencies.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 20, 2022
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2022
@auto-submit auto-submit bot merged commit 32b1f7b into flutter:main Oct 20, 2022
@ditman ditman deleted the update-mocks branch October 20, 2022 19:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@ditman ditman self-assigned this Nov 4, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: google_maps_flutter p: url_launcher p: webview_flutter Edits files for a webview_flutter plugin platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Regenerate webview_flutter_web_test.mocks.dart
2 participants