-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
This is only updating mock files in google_maps_flutter_web and url_launcher_web tests, I don't think this warrants a changelog entry.
I think removing some build_tool dependencies from the pubspec.yaml triggered the versioning alert for webview_flutter_web. I don't think this change warrants a new version. |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Removing "needs tests" since this PR is updating the mocks used to run in CI. |
Yep, flutter/flutter#103602 is tracking making this check understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the mockito mocks of the following web packages:
Fixes flutter/flutter#97815
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.