This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add Mac_x64 darwin_lint_podspecs to LUCI
#6637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Nov 1, 2022
.ci.yaml
Outdated
|
|
||
| targets: | ||
| - name: Mac_x64 darwin_lint_podspecs |
There was a problem hiding this comment.
We should preserve the TODO from the Cirrus config about moving this to ARM.
There was a problem hiding this comment.
Good catch! Added it back.
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| - name: create all_plugins app |
There was a problem hiding this comment.
"lint iOS and macOS podspecs"
.ci.yaml
Outdated
|
|
||
| targets: | ||
| - name: Mac_x64 darwin_lint_podspecs |
There was a problem hiding this comment.
We can drop 'darwin' from the name here; it doesn't really add anything. (I think it was only there because it used to be "ios" and we gave it a generic name instead, when we should have just removed it.)
There was a problem hiding this comment.
Dropped the darwin in both target name here and the script yaml name.
keyonghan
force-pushed
the
plugin_darwin_lint_podspecs_luci
branch
from
517c644 to
5db5fa5
Compare
|
A friendly ping. |
stuartmorgan-g
approved these changes
Nov 4, 2022
No worries at all. Thanks for the review! |
keyonghan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 7, 2022
* 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* add darwin_lint_podspecs * update target file * add args * update path * update script * args list * bringup: true * TODO & Name changes
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* add darwin_lint_podspecs * update target file * add args * update path * update script * args list * bringup: true * TODO & Name changes
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#114813) * 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#114813) * 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* add darwin_lint_podspecs * update target file * add args * update path * update script * args list * bringup: true * TODO & Name changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first Mac target to be enabled in LUCI, and should be landed after recipes support CL: https://flutter-review.googlesource.com/c/recipes/+/35303
Bug: flutter/flutter#114373