This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[quick_actions] Fix Android integration test flake #6688
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2022
* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* Make fix * Formatting
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#115656) * 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#115656) * 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Make fix * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#110022.
The test checks for the content description of the app bar, which is not being explicitly set and thus, includes undetermined accessibility information about the app bar. To combat this issue, this changes the search for the expected description to look for containment within the entirety of the content description versus an exact match.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.