Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Fix Android integration test flake #6688

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Nov 9, 2022

Fixes flutter/flutter#110022.

The test checks for the content description of the app bar, which is not being explicitly set and thus, includes undetermined accessibility information about the app bar. To combat this issue, this changes the search for the expected description to look for containment within the entirety of the content description versus an exact match.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit auto-submit bot merged commit 51d0844 into flutter:main Nov 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 18, 2022
* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…#115656)

* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#115656)

* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709)

* b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610)

* 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572)

* 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597)

* 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688)

* b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quick_actions] Flaky failure in appShortcutLaunchActivityAfterStarting
2 participants