This repository was archived by the owner on Feb 22, 2023. It is now read-only.
CameraX Preview Proof of Concept #6745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public Long setSurfaceProvider(@NonNull Long identifier) { | ||
| Preview preview = (Preview) instanceManager.getInstance(identifier); | ||
| TextureRegistry.SurfaceTextureEntry flutterSurfaceTexture = |
There was a problem hiding this comment.
This value also needs to be released. when the Preview is no longer needed. You may need to add a releaseSurfaceProvider() method to this class wrapper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WILL NOT BE SUBMITTED.
Proof of concept for implementing the preview and related methods in the CameraX plugin.
Part of flutter/flutter#107260
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).