This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Fix file URI construction #6803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
hellohuanlin,
camsim99 and
gaaclarke
as code owners
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2022
* 929c9a632 [camera] Re-enable ability to concurrently record and stream video (flutter/plugins#6808) * f31a438f3 [video_player] Fix file URI construction (flutter/plugins#6803) * 6ab7d710d Roll Flutter from a570fd2 to 521028c (11 revisions) (flutter/plugins#6810)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116781) * 929c9a632 [camera] Re-enable ability to concurrently record and stream video (flutter/plugins#6808) * f31a438f3 [video_player] Fix file URI construction (flutter/plugins#6803) * 6ab7d710d Roll Flutter from a570fd2 to 521028c (11 revisions) (flutter/plugins#6810)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Fix bug in file constructor * Fix comment in interface package * Fix minicontroller for examples/tests/ * Version bumps * Skip file tests on web * Don't use file source in non-file tests, since web doesn't support it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes construction of file URIs by using the relevant
Uriconstructor; since file URIs are URIs, they require escaping, so can't be correctly constructed with naive string interpolation.Fixes flutter/flutter#105950
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).