Feature/switch camera android fix #7185
Conversation
…t PR for cam_avfoundation and cam_android) (flutter#7109)" (flutter#7181)" This reverts commit 66d5724.
|
Here is the PR that fixes that crash on old devices @stuartmorgan. The tests also work correctly for old vs new devices, checking for an error on old and that camera did not switch. The testlab device that failed said it was sdk 26. The Android docs say it should work on >= 26 and I tested with 26 and switching camera does work so Im curious to see how it goes over in testlab |
|
Forgot to update the Java android tests. Will do |
|
@BradenBagby To clarify, is this PR also split from #6478 which I reviewed previously? If so can you update the description? |
|
@bparrishMines Wondering if you have a chance to check this out? Its what you already reviewed before with a few small changes and updated tests |
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
This PR fixes the crash for old devices when switching cameras while recording (Android sdk < 26). See here: #7109
Split from this root PR #6478