Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Plugin template for webview_flutter #746

Merged
merged 9 commits into from
Aug 30, 2018
Merged

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Aug 29, 2018

For reviewer's convenience - 580f760 contains the manual changes for the generated template.

@amirh amirh force-pushed the webview_1_template branch from 2d3b707 to c51ae0a Compare August 29, 2018 23:22
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It seems there are new publishable tests though. You should be able to just delete the example test folder to fix them.

@amirh amirh merged commit d8f3f50 into flutter:master Aug 30, 2018
@amirh amirh deleted the webview_1_template branch August 30, 2018 03:10
teriyakijack added a commit to teriyakijack/plugins that referenced this pull request Aug 31, 2018
* upstream/master:
  Update FOSDC config (flutter#751)
  Add support-v4 dep to ml-vision (flutter#750)
  Add support for firebaseopensource.com (flutter#749)
  Use api to allow support-v4 version resolution. (flutter#748)
  Depend on full support-v4 library for ease of use (flutter#747)
  Plugin template for webview_flutter (flutter#746)
  Fix Java lint warnings in google maps plugin (flutter#745)
  Remove iOS instructions from the maps plugin readme. (flutter#744)
  [image_picker] White line after resize - fixed by adding floor() (flutter#686)
  Port google_maps_flutter to use AndroidView for embedding the map. (flutter#743)
nichtverstehen pushed a commit to nichtverstehen/plugins that referenced this pull request Sep 6, 2018
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants