Skip to content

[simplistic_editor] - Fix delete key on desktop and backspace key on Web #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Oct 4, 2022

Description

This PR updates the simplistic_editor sample to fix some issues related to delete and backspace keys.

For full context, see #1424 (comment)

Related issues

Fixes #1450
Fixes #1413

@domesticmouse
Copy link
Contributor

Can you please re-format for stable?

@bleroux bleroux changed the title [simplistic editor] - Fix delete key on desktop and backspace key on Web [simplistic_editor] - Fix delete key on desktop and backspace key on Web Oct 4, 2022
@Renzo-Olivares Renzo-Olivares self-requested a review October 4, 2022 19:22
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides my one comment. Thanks for making this change!

@bleroux
Copy link
Contributor Author

bleroux commented Oct 5, 2022

@domesticmouse This PR is almost ready to land. I don't know how to disable this step from CI : verify-web-demos (beta)

When it will be ready, thank you to merge it or to tell me how I should proceed (simply push the Squash and merge button? In flutter/fliutter, I'm used to rely on the autosubmit label, that's why I ask).
FYI, when this PR will be merged, I will update #1447 accordingly.

@domesticmouse
Copy link
Contributor

We don't have autosubmit wired up in this repo. Please ignore the failures in the beta web verify. It needs to be updated to honour the beta CI cutout list.

@domesticmouse
Copy link
Contributor

Please feel free to land once the other CI tasks turn green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimplisticEditor: Strange behavior which text changing on click Simplistic Editor: unexpected behavior of TextInputClient on web
3 participants