-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Remove visual samples index #2607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Does this include a redirect to the new page? |
If I understand gh pages correctly (which I might not), would it be easier to add the redirect to the gh pages repo? I made a PR, but I'm unsure if it also requires adding something to this repo. flutter/flutter.github.io#2 |
I'm not sure. The previous tooling published to https://flutter.github.io/samples by using the |
Right now the main ghpages repo redirects to the gh pages set up here when the user navigates to /samples, so when we update that repo, it should just ignore this repo altogether. Because we're in an organization, the base ghpages has to be it's own repo. I also don't have permissions to see or update settings for this repository, so I'm unsure if we need to flip a bit there. @domesticmouse, do you have permissions? |
Hmm, maybe we need an administrator to unpublish this site so that we can redirect |
That said, I think it's okay to merge this PR and verify the behavior afterwards. |
Removes VSI and all related infra. It has been replaced by an index page on flutter.dev
Fixes:
#2582
#2507
Pre-launch Checklist
///
).