Skip to content

Bump tiler for separate M1 macOS goldens + update Cirrus to use M1 Macs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2023

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Jan 21, 2023

This updates https://github.com/DanTup/tiler to a version that has separate golden images for macOS Intel and macOS M1 because the produces images are not identical (see flutter/flutter#118258 (comment)).

The change: DanTup/tiler@3cb0cad#diff-e3add028a0a83d042c0fbf2778df8b172734500140479f80f48354c8373894f9

It also switches Cirrus to M1 Macs (essentially #204) because the old Intel Mac bots are not available and fail immediately.

Fixes flutter/flutter#118258.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@DanTup DanTup changed the title Bump tiler for separate M1 macOS goldens Bump tiler for separate M1 macOS goldens + update Cirrus to use M1 Macs Jan 23, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup DanTup merged commit 3fa5aaa into flutter:main Jan 23, 2023
@DanTup
Copy link
Contributor Author

DanTup commented Jan 23, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer test CI in flutter/tests is failing in the Cirrus Mac environment
2 participants