-
Notifications
You must be signed in to change notification settings - Fork 118
Add patrol tests #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patrol tests #420
Conversation
Uh... @devoncarew ? @natebosch ? |
I'm curious - how much of |
It seems like this is primarily a version-change detection test for the I do think that as we iterate further on the extensibility of the test runner, |
@devoncarew @natebosch I get your point. I removed from the tests the package that directly depends on |
@piotruela it looks like this fell through our review cracks, sorry about that. Would you like to continue with his change and rebase this PR? |
@Piinks Sorry for the late reply. Yes, I'll rebase it asap. |
f097834
to
cbcaf54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM thank you! A change in flutter/flutter will be needed to update the pinned version of flutter/tests after this lands (so flutter/flutter will actually run these tests!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
autosubmit label was removed for flutter/tests/420, because - The status or check suite windows_tests (shard 5 of 5, 4) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Hmm, it looks like this is failing some checks. @piotruela can you try rebasing with the tip of tree here to see if it resolves the issues? |
cbcaf54
to
4e2eb3d
Compare
4e2eb3d
to
1b3e0f9
Compare
@Piinks I've rebased the PR and also updated the script file to work on multiple platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wow this is awesome:) |
This PR add testing 2 packages that are part of the Patrol testing tool:
patrolThey relies on multiple dependencies pinned by the Flutter SDK, most heavily on the
flutter_test
API.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.