-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Adding info on landscape view to Android page. #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe that's correct. Someone more familiar with Android may know better; @jonahwilliams, are you familiar with this part of Android? |
Staging URL Generated At https://flutter-io-deploy-two.firebaseapp.com . Please allow Travis Build to finish to view the URL. |
I believe these are the correct configurations - though it might be worth mentioning somewhere that you almost never want android to restart the activity for a flutter application. Especially since this goes directly against the advice of the Android documentation. So supporting split screen, for example, requires you to add screenLayout and probably density too. |
Please review, @jonahwilliams @willlarche I found a number of things that needed correcting, and also need to fix up the language. Jonah, I added your excellent note about not restarting a Flutter activity from Android. And, Will, I migrated some of your recently added text to the Android page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
Please review, @Hixie.
Staged: https://sz-flutter.firebaseapp.com/flutter-for-android/