Skip to content

Adding info on landscape view to Android page. #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2018
Merged

Adding info on landscape view to Android page. #1037

merged 5 commits into from
May 31, 2018

Conversation

Sfshaza
Copy link
Contributor

@Sfshaza Sfshaza commented May 22, 2018

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label May 22, 2018
@Hixie
Copy link
Contributor

Hixie commented May 22, 2018

I believe that's correct. Someone more familiar with Android may know better; @jonahwilliams, are you familiar with this part of Android?

@FlutterBot
Copy link

Staging URL Generated At https://flutter-io-deploy-two.firebaseapp.com . Please allow Travis Build to finish to view the URL.

@jonahwilliams
Copy link
Member

I believe these are the correct configurations - though it might be worth mentioning somewhere that you almost never want android to restart the activity for a flutter application. Especially since this goes directly against the advice of the Android documentation. So supporting split screen, for example, requires you to add screenLayout and probably density too.

@Sfshaza Sfshaza changed the title Adding info on Adding info on landscape view to Android page. May 30, 2018
@Sfshaza
Copy link
Contributor Author

Sfshaza commented May 30, 2018

Please review, @jonahwilliams @willlarche

I found a number of things that needed correcting, and also need to fix up the language. Jonah, I added your excellent note about not restarting a Flutter activity from Android. And, Will, I migrated some of your recently added text to the Android page.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@willlarche willlarche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants