-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add the go router v14 migration guide #10423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I land this, @ValentinVignal, can you finish the doc? It still has template text and isn't complete. thx
Visit the preview URL for this PR (updated for commit fadc9b4): |
Oops, sorry about that ! I updated the doc |
/gcbrun |
I looked at the linked doc under incognito and it looks... very empty. Also, the images don't render under incognito. |
Sorry @ValentinVignal, I'm used to these having a lot more content. If that's all that is required, sweet. |
That's super weird, on the first loading in an incognito tab, it shows the warning icon instead of the images. But if I load it in a 2nd incognito tab, it displays the images VideoScreen.Recording.2024-04-17.at.9.48.11.PM.mov |
If I start again from scratch:
I still get the same issue 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adds the migration guide for go router v14 (flutter/packages#6495)
Fixes flutter/flutter#146805
Presubmit checklist