Skip to content

Add the go router v14 migration guide #10423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

ValentinVignal
Copy link
Contributor

@ValentinVignal ValentinVignal commented Apr 16, 2024

Adds the migration guide for go router v14 (flutter/packages#6495)

Fixes flutter/flutter#146805

Presubmit checklist

@sfshaza2
Copy link
Contributor

/gcbrun

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I land this, @ValentinVignal, can you finish the doc? It still has template text and isn't complete. thx

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Apr 16, 2024

Visit the preview URL for this PR (updated for commit fadc9b4):

https://flutter-docs-prod--pr10423-patch-3-m3avp5g1.web.app

@ValentinVignal
Copy link
Contributor Author

Before I land this, @ValentinVignal, can you finish the doc? It still has template text and isn't complete. thx

Oops, sorry about that ! I updated the doc

@ValentinVignal ValentinVignal requested a review from sfshaza2 April 17, 2024 01:42
@domesticmouse
Copy link
Contributor

/gcbrun

@domesticmouse
Copy link
Contributor

Before I land this, @ValentinVignal, can you finish the doc? It still has template text and isn't complete. thx

Oops, sorry about that ! I updated the doc

I looked at the linked doc under incognito and it looks... very empty. Also, the images don't render under incognito.

@ValentinVignal
Copy link
Contributor Author

I looked at the linked doc under incognito and it looks... very empty. Also, the images don't render under incognito.

Oh weird, I also don't see the image, I don't know what's happening, I just followed the instructions. Let me investigate.

However, I'm able to see the content, not you?

image

@domesticmouse
Copy link
Contributor

Sorry @ValentinVignal, I'm used to these having a lot more content. If that's all that is required, sweet.

@ValentinVignal
Copy link
Contributor Author

That's super weird, on the first loading in an incognito tab, it shows the warning icon instead of the images. But if I load it in a 2nd incognito tab, it displays the images

Video
Screen.Recording.2024-04-17.at.9.48.11.PM.mov

@ValentinVignal
Copy link
Contributor Author

If I start again from scratch:

  1. Go to flutter.dev/go/template
  2. File > Make a copy
  3. Click Share in the top right
  4. Click “Change to anyone with the link” on the bottom left of the dialog that appears.
  5. Change Viewer to Commenter in the dropdown near the bottom right corner.
  6. Click Done.

I still get the same issue 🤔

@atsansone atsansone added the review.copy Awaiting Copy Review label Apr 17, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit d119f93 into flutter:main Apr 17, 2024
9 checks passed
@sfshaza2 sfshaza2 removed the review.copy Awaiting Copy Review label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the go router v14 migration guide
5 participants