Skip to content

Remove unnecessary floating point values #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Conversation

timsneath
Copy link
Contributor

Coffee-break yak shaving :)

Since Dart 2.1, floating point values can be inferred from integer literals. Converting to the newer, more idiomatic Dart syntax since it is easier to follow.

Also removed one unnecessary type annotation () which is also automatically inferred from the context.

Since [Dart 2.1](dart-lang/language#4), floating point values can be inferred from integer literals. Converting to the newer, more idiomatic Dart syntax since it's cleaner.
@timsneath timsneath requested a review from sfshaza2 September 13, 2019 14:48
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 13, 2019
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye, floating point! LGTM

@sfshaza2 sfshaza2 merged commit e1e38e9 into master Sep 13, 2019
@sfshaza2 sfshaza2 deleted the timsneath-web-int-literals branch September 13, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants