fix apk file open fails in some cases #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 13, 2019 01:02
some apk file's mimetype ends with charset,such as "application/vnd.android.package-archive;charset=utf8" which cause the indent `setDataAndType` with wrong type. In my project, `validateIntent` will failed
merge `getOpenFileIntent` and `validateIntent` validatedFileIntent
getOpenFileIntent => validatedFileIntent
It works instead of removing the `charset` suffix
hnvn
reviewed
Aug 14, 2019
android/src/main/java/vn/hunghd/flutterdownloader/IntentUtils.java
Outdated
Show resolved
Hide resolved
hnvn
reviewed
Aug 14, 2019
android/src/main/java/vn/hunghd/flutterdownloader/IntentUtils.java
Outdated
Show resolved
Hide resolved
add [The try-with-resources Statement ensures each resource is closed] (https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html)
|
I have read a lots of documents about android/java recently, |
|
It's OK, looks better, I will refactor some codes for you |
|
I've just updated your codes, let check it out and make sure it passed your case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. merge
getOpenFileIntentandvalidateIntenttovalidatedFileIntentwhen to comsume it,check the returning Indent is not null then run
startAcitvity(validatedFileIntent)2.In
validatedFileIntentmethod,if original contentType fails
validateIntent, useURLConnection.guessContentTypeFromStream(inputFile) &&URLConnection.guessContentTypeFromName(path)to get workablemimeType