Fix iOS local URL support (fixes #114) #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @rafern thanks for PR. Would it be possible to also add note in README how to access that file? I assume that I need to add it to pubspec? |
|
I've added instructions on how to use the new option to README and fixed the conflicts. There shouldn't be anything else required in the pubspec unless you want to bump the version up. Feel free to ask for anything else. |
|
thanks |
charafau
added a commit
that referenced
this pull request
Apr 7, 2020
Fix iOS local URL support (fixes #114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new WebviewScaffold parameter called localUrlScope which is the allowed directory for the URL and sub-resources. This way, local HTML files can read local resources as well, within the allowed directory set in the new parameter. The file URI scheme is now also allowed. If localUrlScope is null, then the old behaviour is used, in which only the local file is allowed and sub-resources are disallowed.