fix(share_plus): Throw error if sharePositionOrigin not in sourceView

[tkreuder]

(iPad and maybe Mac): The sharePositionOrigin must be in the coordinate space of sourceView. See https://developer.apple.com/documentation/uikit/uipopoverpresentationcontroller/1622324-sourcerect, else [LayoutConstraints] Unable to simultaneously satisfy constraints. appears.

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated the version in pubspec.yaml and CHANGELOG.md.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[tkreuder]

Resolves #951

[tkreuder]

Resolves #870

[miquelbeltran]

Thanks! This will help bring clarity to this issue that seems to affect so many people.

Since sharePositionOrigin is not mandatory for iPhones, does it keep working as well for those devices when the param is not provided?

[tkreuder]

Thanks! This will help bring clarity to this issue that seems to affect so many people.

Since sharePositionOrigin is not mandatory for iPhones, does it keep working as well for those devices when the param is not provided?

I now made sure, that it raises a PlatformException:

• Only if popoverPresentationController is given, which is the case for iPad (not for iPhone) and the arguments sharePositionOrigin value, is not in the parents Rect. This avoids an explicit check, if the device is an iPad and would thus work also on other Apple devices, where this is needed (e.g. in future).
• It raises the PlatformException no matter which Share.share* method is used

[tkreuder]

[tkreuder]

Can this be merged @miquelbeltran ?

[miquelbeltran]

on it

[tkreuder]

Good catch and thank you @miquelbeltran :) 👍

[miquelbeltran]

released under 4.3.0, thanks to you!

I ran this on my mac on both iphone and ipad simulators