Skip to content

[share_plus] fix 'Save Image' option not showing #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022
Merged

[share_plus] fix 'Save Image' option not showing #906

merged 1 commit into from
Jun 13, 2022

Conversation

Coronon
Copy link
Contributor

@Coronon Coronon commented Jun 12, 2022

Description

The 'Save Image' option was not showing when invoking the ShareSheet with share_plus after 4.0.6 which switched to use the before abandoned ShareDate class again. The implementation of activityViewControllerPlaceholderItem did not provide enough context to the OS however to display the image specific options. Other apps that allow sharing were not effected as they relied upon itemForActivityType.

As always, I provide a working example here.

Related Issues

Fixes #897

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Coronon added a commit to Coronon/share_plus_example that referenced this pull request Jun 12, 2022
@miquelbeltran miquelbeltran merged commit 8dde339 into fluttercommunity:main Jun 13, 2022
@miquelbeltran
Copy link
Member

thanks a lot @Coronon for taking care of this! I will release asap

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No save image item shown after upgrading to v4.0.6
2 participants