Skip to content

Add the ability to override the namespace #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

larsmaes
Copy link

@larsmaes larsmaes commented Apr 12, 2025

What this PR does / why we need it:

This PR adds the ability to override the namespace where the flux resources are deployed in. By default it deploys to the release, but now you gain the ability to use it as a sub chart and deploy to its own namespace.

Which issue this PR fixes

fixes #239

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
@thereisnotime
Copy link

I am amazed how many headaches the lack of this caused me. Who in their right mind forgot to put a configurable namespace

@mattwelke
Copy link

@thereisnotime

Normally, the --namespace option lets you set the namespace chart components will be deployed into. This issue only comes up when you use the chart as a subchart.

Let's be nice. I'm glad they've opened this PR to add support for this.

@TylerGillson
Copy link

@stefanprodan thoughts on merging this? We'd really appreciate it! 🙇🏼‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customizing namespace when used as subchart
4 participants