-
Notifications
You must be signed in to change notification settings - Fork 82
Add the ability to override the namespace #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
Signed-off-by: Lars Maes <[email protected]>
I am amazed how many headaches the lack of this caused me. Who in their right mind forgot to put a configurable namespace |
Normally, the Let's be nice. I'm glad they've opened this PR to add support for this. |
@stefanprodan thoughts on merging this? We'd really appreciate it! 🙇🏼♂️ |
What this PR does / why we need it:
This PR adds the ability to override the namespace where the flux resources are deployed in. By default it deploys to the release, but now you gain the ability to use it as a sub chart and deploy to its own namespace.
Which issue this PR fixes
fixes #239
Special notes for your reviewer:
Checklist
make reviewable