Restart analysis if revision changes during validation#31
Merged
stefanprodan merged 3 commits intomasterfrom Jan 18, 2019
Merged
Restart analysis if revision changes during validation#31stefanprodan merged 3 commits intomasterfrom
stefanprodan merged 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 49.1% 53.68% +4.58%
==========================================
Files 8 8
Lines 1010 1030 +20
==========================================
+ Hits 496 553 +57
+ Misses 431 380 -51
- Partials 83 97 +14
Continue to review full report at Codecov.
|
stefanprodan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if there is an canary analysis underway and a new revision is applied on the cluster, Flagger will wait for the new revision to be rolled out and will resume the analysis. This could lead to an erroneous promotion since the new revision will not be fully validated. Instead of resuming the analysis Flagger should reset the validation process (set the failed checks and canary weight to zero) and start a fresh analysis.
Fix #30