Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #757
issue #748
GH Action failing with
SIGBUS
Try running this yourself:
This test modifies badger to run with less memory and frequent flushes to record-limited vlog files.
The loop starts with around 480,000 image repos and each subsequent loop changes a smaller number of those repos, thus triggering compaction -> discard stats -> GC.
This test on my 14 core apple silicon device causes the GC to also hit its edge-case of 1000 max vlog discards.
If you reduce the GC stop deadline, you can also trigger the error case where Badger rejects the GC request and stops the GC run early.
Example log: