Skip to content

Update scala3-library to 3.3.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fmonniot-s-scala-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scala-lang:scala3-library from 3.2.2 to 3.3.1

πŸ“œ GitHub Release Notes - Version Diff - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (3.2.2).
You might want to review and update them manually.

.github/workflows/checks.yml
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, old-version-remains, commit-count:1

@fmonniot
Copy link
Owner

Unfortunately we have to skip the 3.3.x branch. We require a bug fix that is only available in 3.4.0.

@fmonniot fmonniot closed this Nov 26, 2023
@SethTisue
Copy link

We require a bug fix that is only available in 3.4.0.

For the record, mind linking to the issue or PR in question?

@fmonniot
Copy link
Owner

Sure thing. It was discovered in #2 and fixed in scala/scala3#18092.

@SethTisue
Copy link

Hmm. I wonder why the "backport:nominated" label was removed, and if they might reconsider (or at least provide a rationale) if they knew that an important project was blocked from upgrading.

I guess it's not so bad in that your users aren't stuck on 3.2, right? It's only this repo itself that's stuck there for now?

@fmonniot
Copy link
Owner

I guess it's not so bad in that your users aren't stuck on 3.2, right? It's only this repo itself that's stuck there for now?

Yep, as long as users are ok with providing the type manually when invoking the when macro then they can upgrade to the 3.3.x serie.

@fmonniot-s-scala-steward fmonniot-s-scala-steward bot deleted the update/scala3-library-3.3.1 branch November 30, 2023 15:55
This was referenced Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants