Improving quoted functions et al #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support for static call operators (of lambdas and function objects) * Overloaded call operators are now picked by the explicitly specified signature. Note: This was partially done before at the point when creating the quoted function. It is now picked as well when calling the actual call operator.
The library requires C++17, so we could simply remove compiler options for older compilers.
fnc12
approved these changes
Jun 8, 2025
dev/values_to_tuple.h
Outdated
| #ifdef SQLITE_ORM_CONTRACTS_SUPPORTED | ||
| contract_assert(nValues == std::tuple_size<Tpl>::value); | ||
| #else | ||
| (void)nValues; |
There was a problem hiding this comment.
nit: I'd use std::ignore to make it more modern
There was a problem hiding this comment.
I don't know. I am not convinced this is the right usage of ignore. It should only be used for ignoring results (of functions).
trueqbit
force-pushed
the
quoted_functions_et_al
branch
from
9f38a1d to
3251689
Compare
trueqbit
force-pushed
the
quoted_functions_et_al
branch
from
3251689 to
4351c9c
Compare
fnc12
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of scalar application-defined functions from quoted functions and those with a static call operator.
Additionally: