Order by kth column #966
Merged
Order by kth column #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnc12
requested changes
Mar 18, 2022
There was a problem hiding this comment.
I am not sure that 1_nth_col must be added because when user wants to write ORDER BY 1 using sqlite_orm then he/she will write order_by(1) by default. It is not clear for users why order_by(1) will not work but order_by(1_nth_col) will so it would be better to support order_by(1) instead
fnc12
requested changes
Mar 21, 2022
firedaemon-cto
force-pushed
the
issues/order_by_kth_col
branch
from
38454bf to
c96d19e
Compare
firedaemon-cto
force-pushed
the
issues/order_by_kth_col
branch
from
ac35db0 to
1d4ace0
Compare
|
I'll review once #977 is closed |
fnc12
requested changes
Mar 28, 2022
examples/column_aliases.cpp
Outdated
| // FROM marvel | ||
| // ORDER BY 2 | ||
| auto rows = storage.select(columns(&MarvelHero::name, as<colalias_i>(instr(&MarvelHero::abilities, "o"))), | ||
| order_by(get<colalias_2>())); |
There was a problem hiding this comment.
order_by(2) is more intuitive and available to implement. get<colalias_2>() looks weird for newbies and raises questions
|
Alright, there's now an overload for |
fnc12
reviewed
Mar 31, 2022
| struct literal_holder { | ||
| using type = T; | ||
|
|
||
| T value; |
|
thanks @trueqbit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #950.