fix: to_num_from_stream pointer position correction #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdp1
reviewed
Jun 8, 2025
| @@ -109,7 +109,7 @@ module stdlib_str2num | |||
| integer(int8) :: err | |||
| !---------------------------------------------- | |||
| call to_num_base(s,v,p,err) | |||
| p = min( p , len(s, kind = int8) ) | |||
| p = min( p , len(s) ) | |||
There was a problem hiding this comment.
As p is declared as integer(int8), similar issues might still happen. Maybe also declare p as integer :: p? Or do you think it is not needed?
There was a problem hiding this comment.
It is not needed as the kind is converted as an output of min. It could happen if an individual number is written on more than 127 characters. But even a quad number would fit.
perazz
approved these changes
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 9, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 10, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 10, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 10, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 10, 2025
github-actions bot
added a commit
to banana-bred/stdlib
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the computation of the position in a character stream for the
to_num_from_streamfunction to properly advance when the character is a long chain. Otherwise, negative numbers can be obtained fromlen(s, lind=int8)if the string is in effect larger than 127.