Skip to content

Follow GNU install conventions #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jan 6, 2021

Part 1/3 for #287, status: optional. If you do not like this approach we can do #287 without it.

Changes:

  • remove hard coded subpaths for installation with CMake
  • allow customization of install locations by GNUInstallDirs module
  • enable project installation on CI testing (CMake targets are only generated on install)

Reasoning:

  • allows customization of the include directory if it shouldn't go into the top-level include directory
  • makes the life of packagers easier, because we don't have to patch the CMakeLists.txt, but can use command line arguments instead to apply our directory naming conventions

- allow customization of install locations by GNUInstallDirs module
- enable project installation on CI testing
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@awvwgk
Copy link
Member Author

awvwgk commented Jan 11, 2021

Since this is a simple change I will go ahead and merge this PR with two approvals.

@awvwgk awvwgk merged commit dc0ba16 into fortran-lang:master Jan 11, 2021
@awvwgk awvwgk deleted the gnu-install-conventions branch January 11, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants