-
Notifications
You must be signed in to change notification settings - Fork 185
github-ci: add fpm support #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I checked again, the entire CI process seems to be no problem, except that the If you have any questions, you can give me feedback and I will quickly correct it. In addition, once we think there is no problem with this CI, that we can pass it. We need to create a branch, |
Depending on the commit action it will create the branch all by itself, the one used for deploying fpm's documentation will create the branch automatically for example (https://github.com/marketplace/actions/deploy-to-github-pages). |
Also, shouldn't the deployment only happen on push actions for the default branch rather than on PRs as well? For running the action on a PR we don't have to checkout the stdlib-fpm branch at all but just deploy the converted project to a new directory and test it. The checkout is only required for updating the branch on push and this shouldn't be required when running on PRs. |
I think stdlib-fpm needs the existence of the
Thank you for your suggestion @awvwgk , I think both methods are fine.
# When a PR occurs, the fpm package of `stdlib` will be generated.
on: [push, pull_request] Yes, both PR and push will activate |
This comment has been minimized.
This comment has been minimized.
Great stuff @zoziha - thanks for implementing this! The CI is failing currently, because it is trying to deploy the stdlib-fpm package but we don't want to deploy for PRs, only on pushes to master - see my suggestion above. |
- fix all shellcheck warning - don't write into source directory - allow adjusting of destination directory
Minor adjustments to deployment script
Thanks for reviewing and updating Sebastian @awvwgk. It would be good to get another reviewer on this to move it forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest updates to fpm-deployment.sh
look good to me 👍
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and highly needed addition. It will benefit to both stdlib and fpm IMO. Thank you @zoziha .
I approve this PR, pending minor revisions.
I modified the corresponding content of |
Seems like stdlib should go onto the fpm registry but I do not see it there (yet?) |
With 3 approvals, I will merge this PR. Thank you @zoziha |
fpm-deployment
ci;stdlib-fpm
branch. (github-ci will do this job, see github-ci: add fpm support #508 (comment))./ci/fpm.toml
and updateREADME.md
Description
We have this urgent need for fortran-stdlib. We hope that
stdlib
andfpm
can interact, andstdlib-fpm
will be placed in thefortran-lang/stdlib
repository (branch).The CI scheme here comes from @LKedward (https://github.com/LKedward/stdlib-fpm). I have made some modifications to adapt to specific technical requirements. I am not very familiar with CI. I need to admit that the CI scheme this time has shortcomings, but I believe we can iterate and update it.
User efficiency
In order to improve the efficiency of users of
stdlib
, we can set thestdlib-fpm
branch forstdlib
, allowing users to add the following reference in their projects: