Skip to content

faster to_lower and to_upper #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 13, 2023
Merged

faster to_lower and to_upper #733

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a0a03b8
faster to_lower and to_upper
jalvesz Mar 24, 2023
71337ba
Merge branch 'fortran-lang:master' into master
jalvesz Aug 28, 2023
8b7b1e8
faster chat_to_lower/upper
jalvesz Sep 12, 2023
a2aad14
Merge branch 'fortran-lang:master' into master
jalvesz Sep 12, 2023
b8dd3b4
to_lower/upper clearer constants definition
jalvesz Sep 14, 2023
c616095
Merge branch 'master' of https://github.com/jalvesz/stdlib
jalvesz Sep 14, 2023
27e928a
implicit whitespace shift parameter identification
jalvesz Oct 11, 2023
3e0811a
Merge branch 'fortran-lang:master' into master
jalvesz Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/stdlib_ascii.fypp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,11 @@ contains
pure function char_to_lower(c) result(t)
character(len=1), intent(in) :: c !! A character.
character(len=1) :: t
integer, parameter :: wp= 32, la=65, lz= 90
integer, parameter :: wp= 32, BA=iachar('A'), BZ=iachar('Z')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could do the same for wp:

Suggested change
integer, parameter :: wp= 32, BA=iachar('A'), BZ=iachar('Z')
integer, parameter :: wp= iachar('A')-iachar('a'), BA=iachar('A'), BZ=iachar('Z')

Or is it not correct?

integer :: k

!Check whether the integer equivalent is between BA=65 and BZ=90
k = ichar(c)
if (k>=la.and.k<=lz) k = k + wp
if (k>=BA.and.k<=BZ) k = k + wp
t = char(k)

end function char_to_lower
Expand All @@ -237,11 +237,11 @@ contains
pure function char_to_upper(c) result(t)
character(len=1), intent(in) :: c !! A character.
character(len=1) :: t
integer, parameter :: wp= 32, BA=97, BZ= 122
integer, parameter :: wp= 32, la=iachar('a'), lz=iachar('z')
integer :: k

!Check whether the integer equivalent is between la=97 and lz=122
k = ichar(c)
if (k>=BA.and.k<=BZ) k = k - wp
if (k>=la.and.k<=lz) k = k - wp
t = char(k)

end function char_to_upper
Expand Down