Skip to content

Fix warnings [-Wunused-xxx] from compilation #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cyrilgandon
Copy link

@cyrilgandon cyrilgandon commented Oct 2, 2024

Cleaning duty, warnings are generates with

fpm build --verbose --flag '-Wunused-variable -Wunused-dummy-argument -Wunused-parameter'

Progress

  • 42 unused-variable
  • 15 unused-parameter
  • 12/67 unused-dummy-argument
  • 55/67 unused-dummy-argument

Leaving 55 unused-dummy-argument warnings unresolvable, see conversation about those.

@cyrilgandon cyrilgandon changed the title Remove warning -Wunused-variable from compilation Fix warningq -Wunused-xxx from compilation Oct 2, 2024
@cyrilgandon cyrilgandon changed the title Fix warningq -Wunused-xxx from compilation Fix warnings [-Wunused-xxx] from compilation Oct 2, 2024
@cyrilgandon cyrilgandon force-pushed the fix_warning_unused_variable branch from 63659f3 to a59f016 Compare October 3, 2024 09:10
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cyrilgandon.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cyrilgandon for this PR. I have only one minor comment regarding Python procedures. Recently, a procedure of Python >3.9 (?) was introduced in the Fortran stdlib, limiting its compilation on systems supporting most recent versions of Python. It would be nice if this issue can be avoided, hence my question below.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @perazz 's answer, this PR can be merged IMO. Thank you @cyrilgandon for cleaning the code.

@cyrilgandon
Copy link
Author

I still have some fix to do on unused-dummy-argument. This is a bit more complicated because I have to really understand what the code does for some cases

@cyrilgandon cyrilgandon force-pushed the fix_warning_unused_variable branch from a59f016 to b4d81fc Compare October 8, 2024 08:06
@cyrilgandon cyrilgandon force-pushed the fix_warning_unused_variable branch from b4d81fc to f749a16 Compare October 9, 2024 08:36
@perazz
Copy link
Member

perazz commented Oct 22, 2024

It seems like all comments have been addressed. Let's wait one or two days for further comments, and then merge.

@perazz perazz merged commit 427bc68 into fortran-lang:master Oct 30, 2024
16 checks passed
@cyrilgandon cyrilgandon deleted the fix_warning_unused_variable branch November 4, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants